Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Fix salt-ssh state.* commands retcode for render fail #64515

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

lkubb
Copy link
Contributor

@lkubb lkubb commented Jun 21, 2023

What does this PR do?

Ensures a state/pillar rendering failure is reported with a non-zero exit code by salt-ssh.

What issues does this PR fix or reference?

Fixes: #64514

This also adds a test that tried, but failed to reproduce #50727, and a test for general module failure retcodes.

Previous Behavior

exit(0)

New Behavior

exit(20) (the same as all other failures are reported with)

Merge requirements satisfied?

Commits signed with GPG?

Yes

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Fix salt-ssh state.* commands retcode for render fail [master] Fix salt-ssh state.* commands retcode for render fail Jun 21, 2023
@lkubb lkubb changed the base branch from master to 3006.x June 21, 2023 14:02
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Fix salt-ssh state.* commands retcode for render fail [3006.x] Fix salt-ssh state.* commands retcode for render fail Jun 21, 2023
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:18 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:18 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:18 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:18 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:35 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 14:38 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@lkubb lkubb temporarily deployed to ci June 21, 2023 15:44 — with GitHub Actions Inactive
@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 21, 2023

This looks to be ready, but you have this PR in draft mode. Am I good to review?

@lkubb lkubb marked this pull request as ready for review June 21, 2023 19:10
@lkubb lkubb requested a review from a team as a code owner June 21, 2023 19:10
@lkubb lkubb requested review from whytewolf and removed request for a team June 21, 2023 19:10
@lkubb
Copy link
Contributor Author

lkubb commented Jun 21, 2023

@Ch3LL Sure! Since the SSH system is a bit convoluted, I wanted some time to consider alternative approaches, but I'm always happy to read your opinion. And if you're fine with this, so am I. :)

Copy link
Contributor

@Ch3LL Ch3LL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thanks. Let me just get someone else from the core team to review this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] salt-ssh state.* commands: retcode is 0 when state/pillar rendering fails
3 participants